search

minreiseah / pe

0 stars 0 forks source link

Names with "S/O" cannot be added #3

Open minreiseah opened 2 months ago

minreiseah commented 2 months ago

command: add n/rajesh s/o muthu p/93312403 e/vibes@gmail.com a/hello, 123

As this application is a company's employee task manager, not being able to key in certain employees' names is a major issue.

nus-pe-script commented 2 months ago

Team's Response

Special character '/' for names. Subset of #53.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Issue with adding name including special characters

Issue There can be some special characters (e.g., "-", "/") in some people's names, but the current app does not accept these characters in name.

Steps to reproduce Input command: add n/Lee Yi-Han p/82311231 e/aiken@example.com a/Dueet street,block 123, #01-01

Expected Add the person successfully

Actual Report error message that "Names should only contain alphanumeric characters and spaces, and it should not be blank"

Possible improvements Allow some commonly used special characters in names.

Screenshots image.png

[original: nus-cs2103-AY2324S2/pe-interim#40] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We quote the course website as follows:

"It is acceptable to disallow certain characters in input values if there is a justification (e.g., because using those symbols in an input value makes the command harder to parse), but they can still be considered FeatureFlaw bugs if they cause inconvenience to the user. For example, disallowing s/o in a person name because / is used as a command delimiter can cause a major problem if the input is expected to match the legal name of the person."

We are allowed to disallow special characters for ease of parsing so long as the app is not expected to match the legal name of the person. We also have indicated in the UG that we only accept alphanumeric characters. Additionally, it is reasonable to simply avoid the use of non-alphanumeric character as a workaround for the current version.

TaskMasterPro is used personally by the group leader/managers. There is no connection or link to government apps or websites which requires using their legal names. As of current version of the app we will not consider this as causing a major problem for the user that prevents them from using the app.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Medium`] Originally [`severity.High`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]