search

minrk / allthekernels

A multiplexer kernel for Jupyter
MIT License
77 stars 14 forks source link

Wait for the end of the execution of a cell #22

Closed HaudinFlorence closed 2 years ago

HaudinFlorence commented 2 years ago

Using an event synchronization primitive, wait that the execution of a cell is finished before to start the execution of the following one. This should fix https://github.com/minrk/allthekernels/issues/16

davidbrochart commented 2 years ago

You might want to rebase, to resolve conflicts.

HaudinFlorence commented 2 years ago

You might want to rebase, to resolve conflicts.

This has been done

HaudinFlorence commented 2 years ago

Thanks, I just tested it and it works fine! The busy indicator in JupyterLab even has the correct behavior, so I'm not sure anything else is required? Although it could be that JupyterLab only uses the shell messages, but in general we should make sure that the IOPub messages have the right status too,

Thanks for your review. The idea is to complete the implementation in the future with defining a status of all the kernels based on IOPub messages.