minsk-hackerspace / hackerspace.by

Website of Minsk Hackerspace (Ruby on Rails)
https://hackerspace.by/
11 stars 20 forks source link

style: change footer icon size #404

Closed MoskKir closed 4 years ago

abitrolly commented 4 years ago

Pasting screenshot before and after greatly speeds up the review. On Linux (GNOME) you can use Ctrl+Shift+PrtSc and Ctrl+V.

MoskKir commented 4 years ago

before image

after image

abitrolly commented 4 years ago

@MoskKir could you rebase this PR to make tests pass? (I fixed them in master)

cardamo commented 4 years ago

@abitrolly let's teach Travis to build a PR's merge commit instead of head? I mean fetching refs like this for build:

git fetch origin refs/pull/404/merge
abitrolly commented 4 years ago

@cardamo I don't see any setting in Travis to do this. Besides, rebasing is a common operation that is often needed.