minsk-hackerspace / hackerspace.by

Website of Minsk Hackerspace (Ruby on Rails)

https://hackerspace.by/

11 stars 20 forks source link

Users controller: add ssh_keys method to return SSH keys of users #566

Closed jekhor closed 2 years ago

jekhor commented 2 years ago

Fix Cancancan authorization use in hackers controller also for public methods.

Closes: #561

codecov[bot] commented 2 years ago

Codecov Report

Merging #566 (7aa27eb) into master (90ef094) will increase coverage by 0.40%. The diff coverage is 87.50%.

@@            Coverage Diff             @@
##           master     #566      +/-   ##
==========================================
+ Coverage   56.37%   56.78%   +0.40%     
==========================================
  Files          62       62              
  Lines        1341     1356      +15     
==========================================
+ Hits          756      770      +14     
- Misses        585      586       +1

Impacted Files	Coverage Δ
app/controllers/hackers_controller.rb	`65.27% <71.42%> (+0.12%)`	:arrow_up:
app/models/ability.rb	`91.17% <100.00%> (+0.26%)`	:arrow_up:
app/models/user.rb	`69.11% <100.00%> (+1.77%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 90ef094...7aa27eb. Read the comment docs.

jekhor commented 2 years ago

Гэты PR пакуль з метадам без аўтарызацыі. Можа, сыйдземся на тым, што яна непатрэбная.

yahor commented 2 years ago

@jekhor Было б добра юзераў пытацца ці хочуць яны выстазляць ключы ў паблік.

jekhor commented 2 years ago

Ну зараз яны гэта ж робяць праз https://github.com/minsk-hackerspace/ssh-pub-keys

jekhor commented 2 years ago

І ўвогуле:

jek@jeknote:/tmp$ gh api \
  -H "Accept: application/vnd.github.v3+json" \
  /users/yahor/keys
[
  {
    "id": 11827555,
    "key": "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQC37trKk8DR02VCrZdAk+Mg+xktfUfXebNED2LZhIWDYePAhN5orSN6TkyVagiAhHfeTlRa3vjVteYG/d142yrdjfvcia3GqI45mirJ74M37sndzNA+yTNkvf9thr0txwloLW0K3iFbeZ7M5wp0jkAxVwMKDYeSeMJUxGra2lwaH7ORDyolxwqnayKCqjRmJzf+FwoKWNsOJyxxarcXQnhGm9E8q+iHZl2fcmgbteJuZh2jDa/PRrnVg7LOUMdGfC/zIiMO0XvCEyznLblgYHY8rloz3DFA17fTX7gKcKHERbFjRt7D2M1v41lXcXEB1LwZXp9V2u7mkNdvO2K+OlhJ"
  },
  {
    "id": 56532495,
    "key": "ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIGUA6dcIGtnwfv/+6iFqexC2220u2JERmsnSdDSLwjmZ"
  },
  {
    "id": 62954677,
    "key": "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABgQDFALSCL+zJipS+FACVPRw2N8IoZo4whs89m64APOxdbWdzXQeyikdtglm68ksZkz7deFlpdkk619b78qPFB1C8SGkVYqWgDfPpB/X10v2UsfdzqkC2WMoIDV0wkHHQ5z9Pr8cNIlV5BiP5kmPXM4PEsM5THDx4wxUrb08Dz49eca3zg8SzhiBAU7U4cR9+rxp7CT/KuYnleCThbS26ZYiJPX9NoAZrFAwighNJ1zC22qFJ+Z7H1D1NqfWLxkT5CTE6+xxwRfspvKX50uuUgGoEQ2d+GB33Qcbxxt4w89wIYcT/FMEhn2QLoDjAcnf5tUAfiFA3O/6f/qNa17vvbBEg3pQoUQbANsCyvXnIXj5kr7yd0kLeBgihVkfE5dEZy+S4BlWFQliC/O+qqqHGsdA3Ge26NynIIaJh1JgVXi+qlYjOKpbuKxGSH2dHQ7mv8RI5ZhuiLMVjuPUtNYPMpyCqhbPPGk4KN+r0ZfbRg8XzILnWrsSbMf3outjF9C0fl9s="
  },
  {
    "id": 65381431,
    "key": "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQC6+R7D/wHo0JSFC1HUTbtu6vkCpWWBn/rU22231Ov/w1Ak7PCyRoF0NKoSOejsc/Ctj+TT1vNVghM3xEH18se7mlC/xnlbNJe93KvlJl3zadKSWryZHHFtcIKXLyyEOlcwa05UKUyhgM/yqpE6fMNulDkhP+004Z8zfkFnhQkHYJhB4jBquoIZCcXVAxkidAA3zIXeflKU7wvddRA0dYcr3E1nopdsu2mDcc/IvSZ+tpzmEDN9Hv4OOiM2VxQPhREXX9rEdkjAmSTg8ADCjunD3B3W5bNeGjvoIk8PVuAI+aAQin6SUHjaczZbLMvzsXTqi6GSCJY4c0c/Ou/BDwD5"
  }
]