search

minsk-hackerspace / hackerspace.by

Website of Minsk Hackerspace (Ruby on Rails)
https://hackerspace.by/
11 stars 20 forks source link

chore/rails_7.1.x upgrade #611

Closed yahor closed 5 months ago

codecov[bot] commented 5 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3d0ec8b) 57.78% compared to head (03164a9) 5.58%.

Files Patch % Lines
app/models/bank_transaction.rb 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #611 +/- ## ========================================== - Coverage 57.78% 5.58% -52.21% ========================================== Files 66 66 Lines 1445 2006 +561 ========================================== - Hits 835 112 -723 - Misses 610 1894 +1284 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jekhor commented 5 months ago

@yahor нешта я змержыў, не паглядзеўшы, што тэсты валяцца...

/home/travis/.rvm/rubies/ruby-3.1.2/bin/ruby -I/home/travis/build/minsk-hackerspace/hackerspace.by/vendor/bundle/ruby/3.1.0/gems/rspec-core-3.12.2/lib:/home/travis/build/minsk-hackerspace/hackerspace.by/vendor/bundle/ruby/3.1.0/gems/rspec-support-3.12.1/lib /home/travis/build/minsk-hackerspace/hackerspace.by/vendor/bundle/ruby/3.1.0/gems/rspec-core-3.12.2/exe/rspec --pattern spec/\*\*\{,/\*/\*\*\}/\*_spec.rb

An error occurred while loading ./spec/controllers/admin/bank_transactions_controller_spec.rb. - Did you mean?

                    rspec ./spec/controllers/admin/erip_transactions_controller_spec.rb

                    rspec ./spec/controllers/admin/dashboard_controller_spec.rb

                    rspec ./spec/controllers/admin/payments_controller_spec.rb

Failure/Error: require './bepaid.rb'
yahor commented 5 months ago

пагляджу сёння

yahor commented 5 months ago

@jekhor lib/bp_create.rb гэты код пры старце рэйлс павінен выконвацца?

`CSV.foreach(ARGV[0], headers: true) do |rec|

next if rec[1].nil? or rec[1] == '' req = bill[:request] req[:email] = rec[3] req[:order_id] = rec[0] req[:customer][:first_name] = rec[1] req[:customer][:last_name] = rec[2] req[:payment_method][:account_number] = rec[0]

puts JSON.pretty_generate bill

res = bp.post_bill bill puts JSON.pretty_generate res end`

вылезла пасля фікса Failure/Error: require './bepaid.rb вось гэта

ARGV[0] => nil 3.1.2 :047 > CSV.foreach(ARGV[0], headers: true) => #<Enumerator: ...> 3.1.2 :048 > CSV.foreach(ARGV[0], headers: true) {} /Users/yahorzhuchkou/.rvm/rubies/ruby-3.1.2/lib/ruby/3.1.0/csv.rb:1433:in `initialize': no implicit conversion of nil into String (TypeError)