mint-choc-chip-skyblade / sshd-rando

A randomizer for The Legend of Zelda: Skyward Sword HD
GNU Affero General Public License v3.0
28 stars 7 forks source link

Tracker Touchups #381

Closed gymnast86 closed 4 months ago

gymnast86 commented 4 months ago

What does this address?

How did/do you test these changes?

I clicked through all the gratitude crystal numbers and it looked good. I then wrote down some notes and they were properly saved after closing and reopening the program. I tested different fonts for the tracker number labels and they all worked well enough for me to be satisfied.

CovenEsme commented 4 months ago

Looks good. Only thing I noticed was that clicking "Start New Tracker" didn't reset the notes section

gymnast86 commented 4 months ago

That was an intentional decision. Idk why but it felt more natural to me to let the user delete their own notes instead of having them reset when clicking on start new tracker. If it doesn't feel natural to you though, then we can delete them on starting a new tracker.

CovenEsme commented 4 months ago

Yeah, that's fair. It's just something I noticed - I'm happy to leave it how it currently behaves :p

Might be worth adding a "Clear Notes" button? I guess it depends how cluttered the tracker UI is getting

gymnast86 commented 4 months ago

Probably not necessary. You can just ctrl + A or highlight and then delete all your notes which is fast enough imo

CovenEsme commented 4 months ago

Fixed an issue where, regardless of which button you click, 5 gratitude crystals would be added to the counter when using sphere tracking.

Also makes sure the crystal counter doesn't visually update until you select how many crystals you found. Previously, it would add 1 to the counter and then ask you how many you found