mint-choc-chip-skyblade / sshd-rando

A randomizer for The Legend of Zelda: Skyward Sword HD
GNU Affero General Public License v3.0
28 stars 7 forks source link

Fix Assigning Hint Regions #416

Closed gymnast86 closed 2 months ago

gymnast86 commented 3 months ago

What does this address?

Fixes the problem with the Shipyard Dock area being erroneously assigned the hint region from the Shipyard End of Minecart Ride area. Previously the hint region assigning code tried to be smart by grouping any unassigned regions it found in a single pass and applying the found hint regions to all unassigned regions. This doesn't work in the context of the Shipyard End of Minecart Ride area though since the found unassigned regions of the rest of Shipyard shouldn't inherit from Shipyard End of Minecart Ride. Every area just gets assigned individually now.

How did/do you test these changes?

I checked the assignment of each area in the debug log with a few different seeds and it all seemed like it was okay.