search

mint-dewit / hyperdeck-server-connection

Typescript Node.js library for emulating a Blackmagic Hyperdeck
MIT License
10 stars 5 forks source link

Bug / feature Request : Add the GOTO command #5

Closed SNRSE closed 4 years ago

SNRSE commented 4 years ago

I'm submitting a ... [x] bug report [x] feature request [ ] question about the decisions made in the repository [ ] question about how to use this project

Summary Hey i currently use the libary : Hyperdeck server connection. I am missing the Command Goto(n) where n is the clip id which is used to select which clip should be played. i tried to add it myself but failed. Please help me

SNRSE commented 4 years ago

OR could you point me in the direction to add it myself please ?

mint-dewit commented 4 years ago

Hi,

Steps to do this are as follow I think (I'm not sure when I'll have time to get to this so I'll write it out for you)

Add deserialized interface here: https://github.com/baltedewit/hyperdeck-server-connection/blob/master/src/types/DeserializedCommands.ts Add callback in here: https://github.com/baltedewit/hyperdeck-server-connection/blob/master/src/server.ts#L20 Add if statement to call that callback in here: https://github.com/baltedewit/hyperdeck-server-connection/blob/master/src/server.ts#L91

Parameters from the remote connection should already be parsed correctly, as they are defined here: https://github.com/baltedewit/hyperdeck-server-connection/blob/master/src/types.ts#L157

Please note I have not looked at any actual output from the hyperdeck so depending on that it may or may require further work. Hope this helps!

SNRSE commented 4 years ago

when I run yarn build it failes and vscode displays lots of errors do i need to clone into node_modules ? sorry I just started using node etc

mint-dewit commented 4 years ago

Can you try to install version "0.0.4-nightly-feat-gotoCommand-20200604-153336-1ee166e.0"? That should have the goto command added.

SNRSE commented 4 years ago

it works :) thanks alot