search

mint-metrics / mojito-js-delivery

🧪 Source-controlled JS split testing framework for building and launching A/B tests.
https://mojito.mx/docs/js-delivery-intro
Other
16 stars 30 forks source link

Refactor this.inTest() and this.getRecipe() functions so we only read storage once #40

Closed kingo55 closed 4 years ago

kingo55 commented 4 years ago

I wonder if we can refactor this.inTest() and this.getRecipe() so that we read the cookie once and store the information from the cookies on the test object for later re-use? e.g. this.getStoredDecision() -> sets test.options.storedDecision{inTest:1,recipe:0}

allmywant commented 4 years ago

@kingo55 Good point!

kingo55 commented 4 years ago

David, you want to take this issue on once we get a couple of the other PRs merged?

I think it will relate to #31 too.

allmywant commented 4 years ago

@kingo55 Yes, I will take this one.

allmywant commented 4 years ago

@kingo55 Please let me know when this one is ready to start.

kingo55 commented 4 years ago

@allmywant - ready whenever you like, but bear in mind there may be some changes as yet due to #37 (though probably unlikely to affect the get/set test/recipe functions I think).