search

mint-metrics / mojito-js-delivery

🧪 Source-controlled JS split testing framework for building and launching A/B tests.
https://mojito.mx/docs/js-delivery-intro
Other
16 stars 30 forks source link

Add GitHub actions for Mojito JS #48

Closed kingo55 closed 4 years ago

kingo55 commented 4 years ago

This was pretty easy to pop together for #44 .

One issue I had was with adding the gulp new --aa a1 command - I thought it might be a good idea to add this as another test of sorts. But that failed under Node 8.x. Anyway, I figure we should have a more thorough gulp utils test suite as described on #47 .

Regardless, it works fine across different versions of Node.

Have you guys got any feedback on this issue or the Github Actions YML itself?

allmywant commented 4 years ago

@kingo55 I haven't got any feedback on this issue. From the error stack, it failed on below codes:

if (!fs.existsSync(waveFolder)) {
        fs.mkdirSync(waveFolder, { recursive: true });
    }

The node version on my end is 10.15.3, I can have a debug on 8.x if nesserary.

kingo55 commented 4 years ago

@allmywant - thanks. I've only got v10 and v13 here too, so can't check it readily either.

Do lots of people use Node 8? I just used the default suggested Node versions from GitHub Actions.

Might be worth handling with the #47 test suite.

kingo55 commented 4 years ago

@dapperdrop - did you have any comments on this PR?

dapperdrop commented 4 years ago

No comments - looks good. Just approved.