search

mint-metrics / mojito-js-delivery

🧪 Source-controlled JS split testing framework for building and launching A/B tests.
https://mojito.mx/docs/js-delivery-intro
Other
16 stars 29 forks source link

Make test object accessible via ID through Mojito.getTest() #5

Closed kingo55 closed 4 years ago

kingo55 commented 4 years ago

Currently the Mojito.getTest() function expects to see the test object's name. However I think it's more intuitive for us to use the ID to reference test objects.

This PR changes that behaviour. Any thoughts on this guys?

allmywant commented 4 years ago

@kingo55 looking good, ID is better choice.

kingo55 commented 4 years ago

Thanks David - I'll merge this later today then.

On Tue, 24 Sep 2019 at 23:27, David Lee notifications@github.com wrote:

@kingo55 https://github.com/kingo55 looking good, ID is better choice.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mint-metrics/mojito-js-delivery/pull/5?email_source=notifications&email_token=AASAQLBBJO26LYSOERBG3TDQLIITFA5CNFSM4IZ6QEP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7OJ7XY#issuecomment-534552543, or mute the thread https://github.com/notifications/unsubscribe-auth/AASAQLBQXL3DGLIN6ULCYU3QLIITFANCNFSM4IZ6QEPQ .