search

mint-metrics / mojito-js-delivery

🧪 Source-controlled JS split testing framework for building and launching A/B tests.
https://mojito.mx/docs/js-delivery-intro
Other
16 stars 29 forks source link

Add ESLint to the repo #54

Closed kingo55 closed 4 years ago

kingo55 commented 4 years ago

Adding this to the repo so we can keep a consistent style.

Two questions I had:

  1. Should we include ES Lint in the package.json? I didn't want to force the decision upon users who may want their own linting lib, but maybe they could always replace ESLint locally
  2. Should we add the ES lint settings to .gitignore? i.e. for users who want to add their own config on top?
dapperdrop commented 4 years ago

I agree with both suggestions. Linting is best practice, but we don't want to be too prescriptive with our approach.

kingo55 commented 4 years ago

Cheers guys! I'll get this merged...