search

mint-metrics / mojito-js-delivery

🧪 Source-controlled JS split testing framework for building and launching A/B tests.
https://mojito.mx/docs/js-delivery-intro
Other
16 stars 30 forks source link

Bump packages 2021-06 #98

Closed kingo55 closed 3 years ago

kingo55 commented 3 years ago

@dapperdrop and @allmywant - Just updating the packages here.

Would you guys mind checking this out if you have a few minutes?

kingo55 commented 3 years ago

@allmywant - which changes did you end up making there? Looks like Node 8.x doesn't like the upgrades.

allmywant commented 3 years ago

@allmywant - which changes did you end up making there? Looks like Node 8.x doesn't like the upgrades.

I just modified the package.json and bumped package versions exactly same as you did. I'm using Node 10.15.3, what errors you encountered on Node 8.x?

kingo55 commented 3 years ago

Just this issue on globby:

https://github.com/kingo55/mojito-js-delivery/runs/2761038463

Every other version I've tested builds/runs it fine. Makes me wonder whether it's a real issue.

allmywant commented 3 years ago

It seems the del lib caused this issue, previously version was 5.1.0 and upgraded version is 6.0.0. 5.1.0 requires "globby": "10.0.2", 6.0.0 requires "globby": "^11.0.1". I think globby 11.x doesn't support Node 8.x, but they don't say that in https://github.com/sindresorhus/globby. For now, we can downgrade del to 5.1.0 to prevent this issue.

kingo55 commented 3 years ago

Amazing. Thanks for that @allmywant - it's building on Node 8 once more...