Adds ability to swap audio channels from a config file.

mint-n-pepper / DanceBotsEditor

Qt GUI to edit Dancebot Choreographies

https://www.dancebots.ch

GNU General Public License v3.0

4 stars 1 forks source link

Closed philippReist closed 3 years ago

r-oung commented 3 years ago

@philippReist I tested this on Ubuntu and it works as intended. I'll try on a macOS later. Is is possible to create a unit test for this?

philippReist commented 3 years ago

Thank you, Ray! Yes I can unit test this.

@tiemes what is the time line for you to start using this feature?

tiemes commented 3 years ago

@philippReist due to covid-19 we'll not host any workshops before February for sure. We aim to start again in March.

r-oung commented 3 years ago

@philippReist I tested it on macOS and it works as well. Please add a unit test before merging to master.

philippReist commented 3 years ago

@r-oung : I added the audio channel swapping UT and rebased on your MR.

We should bump the minor so this will be v1.1.0.

I will do a functionality test (with 5.12.9) now and then I think we are ready to merge back.