mint-n-pepper / DanceBotsEditor

Qt GUI to edit Dancebot Choreographies
https://www.dancebots.ch
GNU General Public License v3.0
4 stars 1 forks source link

Update actions #64

Closed r-oung closed 3 years ago

r-oung commented 3 years ago
philippReist commented 3 years ago

Let me do a UI functionality test as well with 5.12.9 / maybe it makes sense to see if it works properly with 5.15 LTS.

philippReist commented 3 years ago

Just tested with 5.15.2 - just a few error messages that I think I can fix.

r-oung commented 3 years ago

Sorry, I didn't see your response to this PR for some reason, @philippReist .

I originally created this PR in order to support the latest macOS and Ubuntu OS. While I was doing so, I also decided to update the QT action too. I added 5.12.9 because that was the latest version "officially" supported by the github install-qt-action.

I've tested this on 5.12.9 and 5.12.10. It builds properly, passes all unit tests, and passes functionality test.

I also tried testing this with 5.15.2, but I get the following errors at run-time:

qrc:/qml/components/FrequencySlider.qml:21: TypeError: Cannot read property 'primitive' of null
qrc:/qml/components/FrequencySlider.qml:21: TypeError: Cannot read property 'primitive' of null
qrc:/qml/components/TimerBar.qml:51:3: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
qrc:/qml/components/TimerBar.qml:51:3: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
qrc:/qml/main.qml:167:5: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
qrc:/qml/main.qml:162:5: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
qrc:/qml/components/AudioControl.qml:51:3: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
qrc:/qml/components/AudioControl.qml:38:3: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
qrc:/qml/components/LEDPrimitiveControl.qml:47:3: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
qrc:/qml/components/MotorPrimitiveControl.qml:56:3: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
qrc:/qml/components/MP3FileControl.qml:60:3: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
qrc:/qml/components/MP3FileControl.qml:48:2: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
qrc:/qml/main.qml:72:1: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
qrc:/qml/components/LEDPrimitiveControl.qml:357: TypeError: Cannot call method 'updatePrimitive' of null
qrc:/qml/components/MotorPrimitiveControl.qml:653: TypeError: Cannot call method 'updatePrimitive' of null
qrc:/qml/components/MotorPrimitiveControl.qml:468: TypeError: Cannot read property 'primitive' of null
qrc:/qml/components/MotorPrimitiveControl.qml:208: TypeError: Cannot read property 'primitive' of null

By all means, please fix the errors. However, I'm not sure if we should support 5.15.2 in CI/CD right now because the github install-qt-action only supports 5.12.9 (according to the README). Your thoughts?

philippReist commented 3 years ago

Ah good point - yes then let's stay with 5.12.9. I will do a functionality test this week and then I can update master.

r-oung commented 3 years ago

@philippReist don't forget to merge this in after testing on 5.12.9.

philippReist commented 3 years ago

@r-oung: I rebased the audiochannel swapping MR on top of this so I think we can close this without merging. But best if you double-check that develop has these changes in.

r-oung commented 3 years ago

@philippReist looks good to me. Closing this PR.