search

mint-n-pepper / DanceBotsEditor

Qt GUI to edit Dancebot Choreographies
https://www.dancebots.ch
GNU General Public License v3.0
4 stars 1 forks source link

Add Windows Installer #72

Closed philippReist closed 3 years ago

philippReist commented 3 years ago

Provide installer that:

  1. Extracts and copies files to Program Files or similar.
  2. Creates Desktop/Start Menu shortcut to start GUI.

@philippReist to look into https://www.firegiant.com/wix/ to create MSI from zip file and create shortcuts.

tiemes commented 3 years ago

not sure if we should proceed with this. I think, we could stick with just providing the binaries as zip file.

philippReist commented 3 years ago

I can give it a try, but have not gotten around to it yet.

tiemes commented 3 years ago

up to you :)

philippReist commented 3 years ago

Made some good progress today on the installer: https://github.com/philippReist/DanceBotsEditor/tree/philippReist/wix

Need to finish the file parsing Python script to generate the wxs xml to be parsed by wix.

But this will create .MSI packages that allow:

Right now the installer has no UI, so it just installs into the program files. Can figure out how to add a destination path query, I think that should work. But let's get the installer working first.

philippReist commented 3 years ago

Ok I was too close to stop - now we have a first prototype. Let me know what you think @tiemes.

https://drive.google.com/file/d/11PxUl_B-Su40DrSngIdMd4QnRKgWzuuW/view?usp=sharing

tiemes commented 3 years ago

Awesome! :D Thanks a lot. Installer works like a charm. I didn't test the software afterwards but installation was flaweless.

  1. Is there a way to evade rights elevation (admin)? I dont know if we could change the location and still add a startmenu shortcut.
  2. Is there a way we could include our 30sec. mp3 folder with the installer? We're not allowed to store the mp3 files open on the repo. But if we could add them during the msi building, that would be nice.

We could zoom or call to discuss if thats easier for you :)

philippReist commented 3 years ago

Hmm,

  1. I am not sure if that is possible. I noticed that the installer writes to the registry for shortcut removal along with an uninstall from the win programs and features. Maybe the better approach is still the zip file, but structuring the folder to have a single folder with the executable and dlls in it and then a single shortcut to start the editor.
  2. Yes we can include additional files - but I don't see the difference in being allowed to distribute samples with an installer that is available online vs. having them on the dancebots.ch page. Are you not free to use under 30s samples as you wish?

If a zoom call is easier we can set one up.

tiemes commented 3 years ago

sorry, been a bit busy...

  1. I'm not sure. I quite like the installer though. It will make it easier for ISG ETH Services to manage our laptops as well, if we have an installer. I'll leave it up to you, but I prefer the intstaller.
  2. I'd like to not have the mp3 files as mp3s in an open github repo. In the installer, I dont see any problem as we're allowed to ship them with the program. However if we had it on github, we'd make them publicly available without having to download the whole program and installing it.
philippReist commented 3 years ago

Also sorry for the late reply, had a busy time at work.

  1. If the elevated privileges are ok, we can keep the installer then. You requested this, so you should make the call.
  2. I will leave this completely up to you, as I think fair use copyright defenses are not straightforward. Just tell me what you need.

I think I can finish this next weekend, so we should finalize the plan.

tiemes commented 3 years ago
  1. ok lets keep the elevated installer then.
  2. lets integrate them into the final exe. What will be the path? Still C:/DanceBots? Or C:/program files/DanceBots? Do we just add an "mp3* folder to this?
tiemes commented 3 years ago

@philippReist: we should have an internal Version of the installer with the mp3 library and another without them. Do you have 1 mp3 file with an open licence we could include with the public version? It would be nice, if we could provide the software with 1 song to start.

philippReist commented 3 years ago

Sounds good. Configuring the installer is easy. Will do as soon as possible so we are done with this version.

On Thu, Aug 12, 2021, 11:25 Tobias M. Schifferle @.***> wrote:

@philippReist https://github.com/philippReist: we should have an internal Version of the installer with the mp3 library and another without them. Do you have 1 mp3 file with an open licence we could include with the public version? It would be nice, if we could provide the software with 1 song to start.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/philippReist/DanceBotsEditor/issues/72#issuecomment-897485472, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSKBJS5BLIL2ENCUD65ZLDT4OHPLANCNFSM4WQOR2QQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .