search

mintapi / mintapi

an unofficial screen-scraping "API" for Mint.com
MIT License
1.21k stars 275 forks source link

[FEATURE] Specify Chrome Release #563

Closed pazwicker closed 1 year ago

pazwicker commented 2 years ago

This PR adds a hard-coded chrome release which fixes #553 and #546 for me.

REQUEST: I need help making this an option, not a hard-coded reference to a specfic Chrome release. I'm not sure where to make changes in the code for this and keep things clean/efficient. Would love some help modifying the PR so users can specify a Chrome release in the mintapi.Mint() command.

mrooney commented 2 years ago

Thanks! I'm curious if this would be a good temporary measure to release until the new version works or is supported. Any thoughts @burkematthew ? I agree it would be ideal to make this an argument and simply change the default here.

felciano commented 2 years ago

@mrooney I'd vote for this to be a permanent feature, not a temp measure, as realistically given the nature of mintapi pulling data from an external site, browser issues will continue to crop up. It would be great to have something like --use-chromedriver-from and then pass in a path to a specific, pre-downloaded binary.

mrooney commented 2 years ago

@felciano yup, I'm on the same page! The temporary part I meant was just pinning to 105 :)

mrooney commented 1 year ago

614 is now released in mintapi==2.15, I hope that helps to resolve this issue of dependencies!