mintchaos / typogrify

A set of Django template filters to make caring about typography on the web a bit easier.
http://static.mintchaos.com/projects/typogrify/
Other
168 stars 29 forks source link

functionaliy to ignore content in tags #12

Closed barrysteyn closed 10 years ago

barrysteyn commented 10 years ago

As discussed, functionality has been added here that does the following:

  1. Ignores content between <pre> and <code> tags
  2. Allows the user to specify additional tags where content can be ignored

Some things to note:

Please review and ask me to fix anything if it is needed. Otherwise can this be incorporated as soon as possible.

barrysteyn commented 10 years ago

Hi @ametaireau, as you can probably see, I am more of a c programmer than a Python programmer. Thanks for the tips, I will incorporate everything now and update the pull request.

almet commented 10 years ago

yeah no worries. Have a look at http://www.python.org/dev/peps/pep-0008/ for more info on styling.

almet commented 10 years ago

Haven't tested it but generally speaking it looks okay, apart from what I highlighted.

Also, there are no tests for this project?

barrysteyn commented 10 years ago

I have incorporated all comments made my @ametaireau. I am closing this request because I rebased my git so as not to create spurious commit history. See new pull request.