Closed barrysteyn closed 10 years ago
Hi @ametaireau, as you can probably see, I am more of a c programmer than a Python programmer. Thanks for the tips, I will incorporate everything now and update the pull request.
yeah no worries. Have a look at http://www.python.org/dev/peps/pep-0008/ for more info on styling.
Haven't tested it but generally speaking it looks okay, apart from what I highlighted.
Also, there are no tests for this project?
I have incorporated all comments made my @ametaireau. I am closing this request because I rebased my git so as not to create spurious commit history. See new pull request.
As discussed, functionality has been added here that does the following:
<pre>
and<code>
tagsSome things to note:
<pre>
and<code>
tags from line 151 in filters.py which used them to ignore processing within the caps filter. Seeing as these tags are now not processed by default, it is redundant to leave them in.<math>
tag from the same list. The functionality added in this revision should allow one to ignore<math>
explicitly.Please review and ask me to fix anything if it is needed. Otherwise can this be incorporated as soon as possible.