search

mintchaos / typogrify

A set of Django template filters to make caring about typography on the web a bit easier.
http://static.mintchaos.com/projects/typogrify/
Other
168 stars 29 forks source link

clean up ignore tags code. #15

Closed chrisdrackett closed 10 years ago

chrisdrackett commented 10 years ago

Before we do a release on this I decided to clean the code up so its more readable. I also found a bug with widont where it would apply to all non-ignored sections. Because of this—and the fact that widont only runs within a subset of tags—I now run the widont filter after the ignore process.

@barrysteyn and @justinmayer if you guys review and find everything satisfactory I'll merge this and tag a new version.

justinmayer commented 10 years ago

Looks like this commit won't merge cleanly. (?) It says: "We can't automatically merge this pull request." Were these changes based on current master?

barrysteyn commented 10 years ago

Looks good. Thanks for cleaning up and catching that widont bug. I think this is good to go. At the least, it has my approval!

On 4 February 2014 17:33, Justin Mayer notifications@github.com wrote:

Looks like this commit won't merge cleanly. (?) It says: "We can't automatically merge this pull request." Were these changes based on current master?

Reply to this email directly or view it on GitHubhttps://github.com/mintchaos/typogrify/pull/15#issuecomment-34129237 .

chrisdrackett commented 10 years ago

@justinmayer thats my bad, I moved some stuff around and reverted @barrysteyn commit on master. This branch will merge just fine via. the command line.

justinmayer commented 10 years ago

Cool. Looks okay to me.