search

mintchaos / typogrify

A set of Django template filters to make caring about typography on the web a bit easier.
http://static.mintchaos.com/projects/typogrify/
Other
168 stars 29 forks source link

Fix #18 -- ship titlecase with typogrify. #20

Closed Kwpolska closed 10 years ago

Kwpolska commented 10 years ago

A fix for #18.

cc @chrisdrackett @muffinresearch

PS. the CHANGELOG.rst file is outdated, would you mind fixing that?

justinmayer commented 10 years ago

Looks good to me. As an aside, we should probably hook up TravisCI so the tests are run, and the result indicated here in GitHub, when a pull request is submitted. We've been using that for Pelican, and it's been very helpful.

chrisdrackett commented 10 years ago

I'm all for it if you want to hook it up ;) I've never used Travis (but I've been meaning to try it out)

Kwpolska commented 10 years ago

Considering this requires almost no dependencies at all (as typogrify has no tests yet; it’d be nice to have some!), it’s really a small, easy setup, without needs for performance hacks like I’ve done for Nikola.

And I just implemented it. The only things that needs to be done is setup, which @mintchaos (repo owner) can perform by going to the Travis CI profile page and flicking the switch.

chrisdrackett commented 10 years ago

we have doctests ;)

chrisdrackett commented 10 years ago

also, I think this should probably be handled in another branch / pull request

Kwpolska commented 10 years ago

The travis integration actually depends on this PR. Splitting them would be hard.

Kwpolska commented 10 years ago

There. Moved out Travis CI changes to #21. This is now just the “fix titlecase” issue.