search

mintchaos / typogrify

A set of Django template filters to make caring about typography on the web a bit easier.
http://static.mintchaos.com/projects/typogrify/
Other
168 stars 29 forks source link

Move widont to applyfilters function #31

Open barrysteyn opened 10 years ago

barrysteyn commented 10 years ago

Addresses #30

chrisdrackett commented 10 years ago

@barrysteyn unrelated, but if you have code no need to open a pull request and an issue, just open the pull request and I'll treat it like any other issue :)

chrisdrackett commented 10 years ago

I'm trying to remember why we apply widont at the end like this and not in applyfilters. I have a note that I did that to "fix widont from not processing correctly" but I'm not sure what I mean by that... I'll explore when I have time, but feel free to chime in (anybody).

barrysteyn commented 10 years ago

Okay, no problem regaring the issue thing (it makes life easier actually :) ).

@chrisdrackett, it was originally in applyFilter, but at the last minute, you moved it. At the time, you told me it was not anything inherently wrong with keeping it in applyFilters, but that widont was "clever" enough not to be needed to be in the applyFilters function. To tell you the truth, it does not bother me, but I get a lot of emails and some issues asking me to please also make ignore apply to widont.

justinmayer commented 10 years ago

I propose that we merge this change, and if we find a case where the widont filter is not processing correctly, address it at that time and be sure to include an appropriate test case. (^_^)

chrisdrackett commented 10 years ago

thats fine we me, I've been swamped at work and just haven't have time to merge, test and release.

justinmayer commented 3 years ago

@barrysteyn: Please accept my sincere apologies for the absurdly long delay in reviewing your contribution. Truly.

I just tested the code in this PR with Pelican 4.5.1, and I'm seeing the following fatal error repeated for every page and post in content:

ERROR: Could not process posts/example-post1.md
  | unsupported operand type(s) for +: 'map' and 'list'
ERROR: Could not process posts/about.md
  | unsupported operand type(s) for +: 'map' and 'list'
[…]

Any thoughts on why that might be?