mintchaos / typogrify

A set of Django template filters to make caring about typography on the web a bit easier.
http://static.mintchaos.com/projects/typogrify/
Other
168 stars 29 forks source link

fix python 3 code error: map + list #34

Closed aravindavk closed 10 years ago

aravindavk commented 10 years ago

In Python 3 map returns map object but in python 2 map returns list. casted "map" as "list" works both in 2.x and 3.x

Signed-off-by: Aravinda VK mail@aravindavk.in

justinmayer commented 10 years ago

Thanks, Aravinda.

@chrisdrackett: As an aside, Typogrify 2.0.5 doesn't show up in on GitHub releases/tags. For the next release, we should be sure to push tags to GitHub at the same time we upload to PyPI. (^_^)

chrisdrackett commented 10 years ago

@justinmayer thanks! I'm using tower now, which doesn't auto-publish tags like gitbox did ;)

justinmayer commented 10 years ago

@chrisdrackett: Any chance you might be able to issue a 2.0.6 release containing this bug fix? This problem seems to be causing Pelican builds to fail. I'd issue the release myself, but I'm organizing a charity fundraiser this weekend and am flying out-of-town first thing on Monday.

sscherfke commented 10 years ago

You may also want to update the changelog … ;-)

sscherfke commented 10 years ago

Btw, now I get unsupported operand type(s) for +: 'filter' and 'filter' – filter() returns a generator in Python 3, so + won’t work here.