search

mintdigital / pyrite

Easy peasy in-browser testing with Selenium
MIT License
16 stars 1 forks source link

wait_for_page does not work with latest selenium-client (1.2.18) #5

Closed chrisvariety closed 14 years ago

chrisvariety commented 14 years ago

Here's the error message:

http://gist.github.com/439640

Fixing this looks pretty easy, I just didn't want to go through all the forking/patching hassle.

I only changed one line in dsl.rb, from:

browser.wait_for_page_to_load :page

to:

browser.wait_for_page_to_load 10

That's a timeout, in seconds.

rodreegez commented 14 years ago

Thanks for this, I'll get a fix in first thing tomorrow.

rodreegez commented 14 years ago

So, after totally missing your point, I see what went wrong here...

Going with the selenium-client idiomatic api (http://selenium-client.rubyforge.org/classes/Selenium/Client/Idiomatic.html#M000070) rather than specifying a timeout_in_seconds.

rodreegez commented 14 years ago

Just pushed this fix in Pyrite 0.5.9

chrisvariety commented 14 years ago

Thanks, your fix is way better than mine. I fail at reading docs.

Just tested it and it works great!