mintel / build-harness

🤖Collection of Makefiles to facilitate building Python/Golang projects, Dockerfiles, and more
Apache License 2.0
2 stars 6 forks source link

Support running (most) commands against docker image #45

Closed nabadger closed 4 years ago

nabadger commented 4 years ago

I'm trying to promote running most of our development commands against a docker image.

Typically this would cover

We shouldn't require python/pipenv/pytest/python etc to be installed locally to be able to develop an app :)

nabadger commented 4 years ago

I was a bit confused about the command that the user would run here.

Would something like the following make sense?

I know there a docker module already, so maybe we could just extend that (or invent a new one)

charlieparkes commented 4 years ago

The idea with the modules is that they are a collection of flags/calls for a specific executable rather than just a place we put any command that calls that executable.

So, modules/docker would be boilerplate "generic things you'd want to do with docker" as opposed to "any command that has docker in it." Perhaps we create a new layer for a generic build container (modules/ci?) or we put the generic build container calls in language specific layers (modules/python/Makefile.ci)? I've only given it a little thought so far, since we need to come up with a good way to do these generic build containers first.

nabadger commented 4 years ago

This is perhaps more about how we want to install deps when using build-harness (build-harness-packages, apk, docker (single image vs app-specific).

Closing this for now but will re-open once we decide next steps.