mintel / build-harness

🤖Collection of Makefiles to facilitate building Python/Golang projects, Dockerfiles, and more
Apache License 2.0
2 stars 6 forks source link

Use local black and isort option #65

Open dmitchell-mintel opened 4 years ago

dmitchell-mintel commented 4 years ago

Check for black and isort in the pipenv and use them if found

nabadger commented 4 years ago

Let's put this on hold until we figure out some direction from the meeting on Friday.

Regarding build-harness there's a few options for handling dependencies.

1 - Install packages locally. This actually works really well (see https://github.com/cloudposse/packages ), and essentially means you can re-use this in CI and local (via make package/install/$package). These are most often static-bins so fairly portable.

2 - Alpine Linux Packages ( https://github.com/cloudposse/packages ) also supports ALP, which gives us another route (i.e. add the repo and apk-add). This could be bundled into a base image.

3 - Docker - either a common image bundle (which could just be the pipeline image itself), or calling out to specific docker-images (like we're doing here). There's pros and cons of each

There's a couple variants of docker still, such as using COPY FROM against upstream, vs cURL and install locally.