search

mintel / build-harness

🤖Collection of Makefiles to facilitate building Python/Golang projects, Dockerfiles, and more
Apache License 2.0
2 stars 6 forks source link

py.toml changes are breaking faas commands #71

Open charlieparkes opened 3 years ago

charlieparkes commented 3 years ago 
cd /home/travis/build/alphachai/boto3-fixtures/dummy_lambda/dist && zip build.zip pyproject.toml

    zip warning: name not matched: pyproject.toml

zip error: Nothing to do! (build.zip)

/home/travis/build/alphachai/boto3-fixtures/build-harness/modules/faas/Makefile:38: recipe for target 'faas/build/python/zip' failed

make[1]: *** [faas/build/python/zip] Error 12

Lack of a pyproject.toml breaks faas/build/python/zip.

charlieparkes commented 3 years ago

@aspage2

aspage2 commented 3 years ago

What should the expected behavior here be? Initial thought would be to swallow the error and just create build.zip without a pyproject.toml:

faas/build/python/zip:
    ....
    cd $(FAAS_BUILD_DIST) && (zip build.zip pyproject.toml || true)
    ....
charlieparkes commented 3 years ago

Yeah, I think that would work 👍