search

mintel / dex-k8s-authenticator

A Kubernetes Dex Client Authenticator
MIT License
371 stars 146 forks source link

Added Annotations section to Deployment template #142

Open VF-mbrauer opened 3 years ago

VF-mbrauer commented 3 years ago

To make it possible to have an annotations section defined which we can fill with data. Right now it is static data and just filled with checksum/config: This makes it more flexible to give also other customized key/value pairs defined there.

nabadger commented 3 years ago

@VF-mbrauer - just wondering if you saw my reply or not, and whether these changes are still required?

Thanks

jengo commented 3 years ago

I would personally like to see this merged in. I need annotations to allow connecting to hashicorp vault.

VF-mbrauer commented 3 years ago

@VF-mbrauer - just wondering if you saw my reply or not, and whether these changes are still required?

Thanks

Hi @nabadger, apologize for the late reply. I found also another way of implementation on our side via Admission Controller functionality, but I still see this feature as important as for users not implementing this that way I mentioned. Therefore this should be implemented the way we discussed already. Thanks.

nabadger commented 3 years ago

@VF-mbrauer would you be able to rename this to podAnnotations? If not I can do this in a different MR and merge it in :)

VF-mbrauer commented 3 years ago

Hi @nabadger, yes of course. Feel free to amend for me and get it merged. Then we can finally close this thread. Thanks.

VF-mbrauer commented 2 years ago

@nabadger Any news here. Did you amend and merged that in the meantime?