search

mintel / dex-k8s-authenticator

A Kubernetes Dex Client Authenticator
MIT License
371 stars 146 forks source link

Allow use of custom secret name #148

Closed paveq closed 2 years ago

paveq commented 3 years ago

In some (most? )cases it is preferable to manage secret outside of the chart, via eg. sealedSecrets. This PR implements feature to use custom secret name.

paveq commented 3 years ago

Shouldn't the $ in {{ template "dex.fullname" $ }} rather be a . (dot)? This line can also be written as: {{ default (template "dex.fullname" .) $envSecretName }}

I did not actually change that part of the original line, that is still working as before my commit.

I don't have enough knowledge of Helm templating to really comment if something should be changed here or not, in my testing how it is currently did work.

nabadger commented 3 years ago

I'll take a look at this soon, just out for holidays at the moment! :)