mintel / dex-k8s-authenticator

A Kubernetes Dex Client Authenticator
MIT License
374 stars 146 forks source link

allow for base64 encoded k8s ca #171

Closed jbonzo closed 3 years ago

jbonzo commented 3 years ago

We found that when using templating tools its much easier to allow for base64 encoded CAs.

jbonzo commented 3 years ago

It seems that circleci is failing cause there is no circleci config present in this repo. Did I prepare this PR incorrectly or is there something else going on?

nabadger commented 3 years ago

It seems that circleci is failing cause there is no circleci config present in this repo. Did I prepare this PR incorrectly or is there something else going on?

We replaced circle with github-actions - I've just found a leftover web-hook on the repo settings for circle which is now removed, so should have fixed it going forward (for now we can ignore the circle build error).

jbonzo commented 3 years ago

Would you mind adding this a configuration-option in the features docs?

https://github.com/mintel/dex-k8s-authenticator/blob/master/docs/config.md#configuration-options

Many thanks

Of course