mintel / dex-k8s-authenticator

A Kubernetes Dex Client Authenticator

MIT License

371 stars 146 forks source link

Dex chart should be removed from repository #73

Open solovyevt opened 5 years ago

solovyevt commented 5 years ago

It is redundant to keep Dex Helm chart in this repository, we should leave dex-k8s-authenticator chart and a good explanation of how to integrate it with Dex chart taken from stable/Dex repository.

nabadger commented 5 years ago

34

I tend to agree. I'll work on some docs.

nickmintel commented 5 years ago

Moving forward with this:

Drop dex chart and current documentation for it in this repo
Add new documentation
- Direct users to https://github.com/helm/charts/tree/master/stable/dex
- Update examples/docs to show how you can use both

nabadger commented 5 years ago

92

nabadger commented 5 years ago

See https://github.com/helm/charts/blob/master/CONTRIBUTING.md#technical-requirements

Some things to note:

dex-k8s-authenticator currently goes into crash state until it can resolve dex-idp
Add a requirements.yaml and make dexidp a dependency

desaintmartin commented 5 years ago

It would be a good excuse to get dex-k8s-authenticator listed in hub.helm.sh (https://github.com/helm/hub/blob/master/Repositories.md)!

kostyrev commented 5 years ago

I was about to migrate to stable/dex chart but as of version 2.0.0 that chart only exposes subset of configuration.
I could not use frontend: subsection and that's a bummer. I'd like you to reconsider dropping dex chart from this repository. At least for a while.

nabadger commented 5 years ago

@kostyrev would you be able to create a feature-request on the upstream dex repo for this? I can then track it and base any decision from it too.

I haven't managed to find much time to progress this in anycase just yet as other things keep coming up :)

Keep in mind the existing tagged releases will still be around.

kostyrev commented 5 years ago

you could use https://github.com/helm/charts/issues/16351