search

mintel / dex-k8s-authenticator

A Kubernetes Dex Client Authenticator
MIT License
371 stars 146 forks source link

livenessProbe and readinessProbe paths #81

Closed kostyrev closed 5 years ago

kostyrev commented 5 years ago 
-     chart: dex-k8s-authenticator-0.1.2
+     chart: dex-k8s-authenticator-1.1.1
      release: dex-k8s-authenticator
      heritage: Tiller
  spec:
    template:
      metadata:
        labels:
          app: dex-k8s-authenticator
      spec:
        containers:
        - name: dex-k8s-authenticator
          image: "mintel/dex-k8s-authenticator:1.1.0"
          livenessProbe:
            httpGet:
-             path: /
+             path: /healthz
              port: http
          readinessProbe:
            httpGet:
-             path: /
+             path: /healthz
              port: http

Is that what it should be set to by default? curl for /healthz shows the same "Generate Kubernetes Token" page as before.

nabadger commented 5 years ago

@kostyrev At the moment yes. I wanted to add a dedicated health and readiness endpoint (the readiness would probably check that Dex is accessible).