search

mintel / dex-k8s-authenticator

A Kubernetes Dex Client Authenticator
MIT License
371 stars 146 forks source link

Fix Windows tab commands #86

Open lightnet328 opened 5 years ago

lightnet328 commented 5 years ago

The commands listed in the Windows tab do not actually work on Windows. I fixed it.

nabadger commented 5 years ago

@lightnet328 thanks - Since I'm not familiar with Windows/Powershell, I'm going to run this PR by a few of our users/devs who run Windows to make sure it still works for them too.

Thanks!

lightnet328 commented 5 years ago

I used cmd.exe on Windows 10 to check the behavior of the command before and after the modification.

TomasKohout commented 3 years ago

Hi guys,

could you merge this into the master and release it, please? Our users complain that Windows setup do not work properly and since this PR exists I won't create my own.

Best regards Tom

marians commented 2 years ago

Hi! We have a few Windows users running into this problem and would be happy if the PR could get merged.

An additional problem is that Windows users have two shells in general: cmd.exe and PowerShell. Knowing which one is supposed to work (here: cmd.exe) would help remove the guesswork.

anvddriesch commented 2 years ago

Hey, What is the process on this PR? Is there something we can do to help getting this merged?