search

mintel / dex-k8s-authenticator

A Kubernetes Dex Client Authenticator
MIT License
371 stars 146 forks source link

Updating helm repo's index.yaml with temporary URLs (in till it gets … #92

Closed bstascavage closed 5 years ago

bstascavage commented 5 years ago

…merged into master)

bstascavage commented 5 years ago

This is in response to Issue 70, where a helm chart index.yaml was added. Unfortunately, since it is on another branch, in till that is merged into master, the index.yaml is broken. This PR is a quick fix for the duration this code lives on the feat-helm-repo branch.

nickmintel commented 5 years ago

@bstascavage Sorry - that previous case kinda stalled. I'm not really maintaining that branch, but I think we should merge this in anyway.

Maybe you can give your view on this?

I'm thinking we create a github.com/mintel/mintel-helm-charts repo - and push any related charts to there instead. So the new charts repo would not be within this mintel/dex-k8s-authenticator repo.

The only charts we would have (at least for now) would be dex & dex-k8s-auth.

Does this sound right?

bstascavage commented 5 years ago

So one question I have is, why are you maintaining your own chart of dex? I used the base Dex with your dex-k8-authenticator and had no issues with it. That would make it so that you had to only maintain one thing.

Anyways, your proposed solution sounds good for the time being but the real solution would be to move your chart over to the official helm repo if possible. This way, you don't have to worry about tarring up your own artifacts, nor users having to add another repo just for your app.