search

mintel / pytest-localstack

Pytest plugin for local AWS integration tests
MIT License
78 stars 17 forks source link

WIP: Fix DeprecationWarnings by updating pytest.config to request.config #14

Closed charlieparkes closed 5 years ago

charlieparkes commented 5 years ago

Add request to fixtures using _make_session, and update _make_session to use request.config instead of pytest.config

https://docs.pytest.org/en/latest/deprecations.html#pytest-config-global

jtdoepke commented 5 years ago

LGTM. Tests failed because black doesn't run in Python 2.7; I'm looking at dropping support for 2.7.

charlieparkes commented 5 years ago

Sweet - WIP while I get our service to pass. Otherwise, I think it's good to go.

jtdoepke commented 5 years ago

@alphachai did this work? If so, can you do a rebase so I can merge it?

charlieparkes commented 5 years ago

I haven't finished testing it yet. I'll update within the next day or so.

ghost commented 5 years ago

@jtdoepke @alphachai According to the pytest docs as this is a plugin we should not be using request, we should be using pytest_configure instead.

ghost commented 5 years ago

Also, we don't need this command-line option, as pytest -p no:localstack does the same.

charlieparkes commented 5 years ago

Replaced by #17