josh-drapeau commented 5 years ago

If we aren't explicitly passing in a region to work with, allow botocore to select one for us!

jtdoepke commented 5 years ago

Rebase?

josh-drapeau commented 5 years ago

I've pulled in the Travis test fixes, and things are looking good!

codecov[bot] commented 5 years ago

Codecov Report

Merging #15 into master will decrease coverage by 0.23%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
- Coverage    59.6%   59.37%   -0.24%     
==========================================
  Files          10       10              
  Lines         614      635      +21     
==========================================
+ Hits          366      377      +11     
- Misses        248      258      +10

Impacted Files	Coverage Δ
pytest_localstack/__init__.py	`45% <ø> (+6.7%)`	:arrow_up:
pytest_localstack/contrib/boto3.py	`51.72% <ø> (-5.42%)`	:arrow_down:
pytest_localstack/contrib/botocore.py	`71.49% <ø> (-0.01%)`	:arrow_down:
pytest_localstack/session.py	`65.89% <100%> (-0.38%)`	:arrow_down:
pytest_localstack/service_checks.py	`44.77% <0%> (-6.08%)`	:arrow_down:
pytest_localstack/utils.py	`62.5% <0%> (-1.61%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 89c34ed...261753f. Read the comment docs.

mintel / pytest-localstack

Use botocore for default region #15

Codecov Report