search

mintel / pytest-localstack

Pytest plugin for local AWS integration tests
MIT License
78 stars 17 forks source link

Allow single port localstack versions. Fix patching STS endpoint_url. #36

Closed LiamCato closed 4 years ago

LiamCato commented 4 years ago

New versions of localstack have removed the deprecated port-per-service ports. For backwards compatibility we can switch between the new single port and the legacy ports based on the localstack_version argument.

Also, it appears that in new versions of botocore the endpoint url of STS is no longer patched correctly (additional logic applies to STS which sets the endpoint_url back to the global url after resolving the endpoint) so add an additional patch to keep it patched.

codecov[bot] commented 4 years ago

Codecov Report

Merging #36 into master will increase coverage by 0.40%. The diff coverage is 53.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage   59.55%   59.96%   +0.40%     
==========================================
  Files          10       10              
  Lines         633      617      -16     
==========================================
- Hits          377      370       -7     
+ Misses        256      247       -9
Impacted Files Coverage Δ
pytest_localstack/constants.py 0.00% <0.00%> (ø)
pytest_localstack/session.py 66.28% <50.00%> (+0.20%) :arrow_up:
pytest_localstack/contrib/botocore.py 70.58% <100.00%> (+0.40%) :arrow_up:
pytest_localstack/__init__.py 41.46% <0.00%> (-0.40%) :arrow_down:
pytest_localstack/utils.py 64.10% <0.00%> (+1.60%) :arrow_up:
pytest_localstack/service_checks.py 50.98% <0.00%> (+1.92%) :arrow_up:
pytest_localstack/contrib/boto3.py 55.55% <0.00%> (+3.83%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update be434a0...8e7a91f. Read the comment docs.