search

mintel / pytest-localstack

Pytest plugin for local AWS integration tests
MIT License
78 stars 17 forks source link

Allow LocalstackSession to take hostname argument #41

Closed xiang-zhu closed 3 years ago

xiang-zhu commented 3 years ago

When docker daemon started with different DOCKER_HOST, the default 127.0.0.1 can't be used to communicate with started localstack container. This change make LocalstackSession take hostname argument and use it instead of the default 127.0.0.1 if specified.

codecov[bot] commented 3 years ago

Codecov Report

Merging #41 (f2731aa) into master (cc0e3e3) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #41   +/-   ##
=======================================
  Coverage   61.01%   61.01%           
=======================================
  Files          10       10           
  Lines         631      631           
=======================================
  Hits          385      385           
  Misses        246      246
Impacted Files Coverage Δ
pytest_localstack/session.py 65.90% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cc0e3e3...f2731aa. Read the comment docs.