search

mintel / pytest-localstack

Pytest plugin for local AWS integration tests
MIT License
78 stars 17 forks source link

Review flake8 ignore rules #7

Closed jtdoepke closed 6 years ago

jtdoepke commented 6 years ago

The flake8 ignore rules were mostly cargo-culted. Make sure they still matter.

E133: closing bracket is missing indentation
D104: Missing docstring in public package
D105 Missing docstring in magic method
D107: Missing docstring in __init__
D203: 1 blank line required before class docstring
D212: Multi-line docstring summary should start at the first line
D213: Multi-line docstring summary should start at the second line
D301: Use r""" if any backslashes in a docstring
D400: First line should end with a period
D404: First word of the docstring should not be "This"
D401: First line should be in imperative mood
D402: First line should be in imperative mood; try rephrasing
F812: list comprehension redefines ...
H101: Use TODO(NAME)
H202: assertRaises Exception too broad
H401: docstring should not start with a space
H403: multi line docstrings should end on a new line
H404: multi line docstring should start without a leading new line