search

mintlayer / mintlayer-core

Mintlayer Core: The central repository housing the essential components to operate a Mintlayer node. It encompasses the node and wallet functionalities necessary for seamless operation, alongside an additional API server designed to facilitate applications.
https://www.mintlayer.org
MIT License
43 stars 27 forks source link

Deal with `OP_CODESEPARATOR` #171

Closed iljakuklic closed 1 year ago

iljakuklic commented 2 years ago

Have to decide on behaviour of the instruction in Scripts. Most likely just disable it.

TheQuantumPhysicist commented 1 year ago

Seems like it's been officially killed on multiple levels... especially with the presence of taproot

https://bitcoinops.org/en/topics/op_codeseparator/

Even transactions relaying with it won't work.

I think we should drop it and move on. It seems that with the presence of taproot, it's useless because two leaves can simulate its effect anyway.

About our bitcoin script, we can consider enabling it there (which is another discussion). But for standard formats, I don't see why we would go through this.

I hope I'm not missing something big.

iljakuklic commented 1 year ago

Yep, that is my impression as well. I haven't seen a compelling example of its use anywhere. In addition to that, miniscript does not support OP_CODESEPARATOR either, as a further indication it's not deemed a well-behaved operation.