mintlayer / mintlayer-core

Mintlayer Core: The central repository housing the essential components to operate a Mintlayer node. It encompasses the node and wallet functionalities necessary for seamless operation, alongside an additional API server designed to facilitate applications.
https://www.mintlayer.org
MIT License
43 stars 24 forks source link

Fix leaky tests detected by nextest #762

Open TheQuantumPhysicist opened 1 year ago

TheQuantumPhysicist commented 1 year ago

When running unit tests with nextest, it detects leaky tests, which are defined as tests that don't clean-up properly when they finish. We should investigate this.

Note: For some reason, these are only detected on Windows. For me, I saw them when running the tests in git bash. This isn't found/detected by Linux or Mac.

discosultan commented 1 year ago

Also experienced similar warnings on Windows with Git Bash. The warnings are intermittent and not trivially reproducible. Here are a few examples:

LEAK [   0.138s] common chain::transaction::signature::tests::mutate_none::case_1
LEAK [   0.187s] crypto hash::tests::test_hash_sha3_512
LEAK [   0.184s] crypto hash::tests::test_ripemd160
LEAK [   0.184s] crypto hash::tests::test_ripemd160_stream