mintlayer / mojito_mobile_wallet

MIT License
7 stars 2 forks source link

Restructure the folder #92

Open macaroni7 opened 1 year ago

macaroni7 commented 1 year ago

Context

The current root folder contains all the subfolders related the product development, such as components, screens etc, this makes it a bit hard to maintain the features.

├── assets
│   └── fonts
├── blue_modules
│   ├── aezeed
│   │   └── src
│   ├── bc-bech32
│   │   └── dist
│   ├── bc-ur
│   │   └── dist
│   └── ur
├── class
│   └── wallets
├── components
│   └── addresses
├── constants
├── core
│   └── react-native-tor
├── helpers
├── img
│   ├── addWallet
│   │   └── btcBig
│   ├── bottomTab
│   ├── circle_logo
│   ├── header_logo
│   ├── intro
│   ├── mshelp
│   ├── qr_code
│   └── splash
├── loc
├── models
├── screen
│   ├── NativeAssets
│   ├── introduction
│   ├── lnd
│   ├── receive
│   ├── send
│   ├── settings
│   ├── transactions
│   └── wallets
├── scripts
│   └── maccatalystpatches
├── store
├── tests
│   ├── e2e
│   ├── integration
│   └── unit
│       └── fixtures
├── theme
├── typings
└── windows
    └── bluewallet
        └── Assets

Suggestion

It would be good to move these files and folders to src folder, only leave the configuration files in the root folder. It will be much clean and easier to manage the features and functionalities.

The folders and files can move to src:

- assets/fonts
- class
- components
- constants
- helpers
- img
- models
- screen
- store
- theme
- blueComponents.js
- Navigation.js
- NavigationService.js
- UnlockWith.js
amalikmuhd commented 1 year ago

I will be working on it

renie commented 1 year ago

This seems to be a nice idea. But as it might generate lots of breaking changes, and will affect hundreds of files, it would be nice to have small and very specific PRs for that issue. That way it would be much easier to review and recheck tests. See more related data here.