search

mintlify / components

UI components for documentation made with React and TailwindCSS.
MIT License
79 stars 12 forks source link

Cards should accept an image prop #57

Closed handotdev closed 1 year ago

handotdev commented 1 year ago

Summary

Card right now only accepts icons. However, a true Card should have an image property that sits above the card and covers the entire spacing like so

CleanShot 2023-02-07 at 23 03 30@2x
sboy99 commented 1 year ago

Interested! I think it is almost the same as icon prob but it will only take string props. And will be rendered on top to the card. Assign me I will try my best.

sboy99 commented 1 year ago

@tobias-mintlify should I start working on this I'm really looking forward to contribute.

ghost commented 1 year ago

@sboy99 Yes, no one has started on this so it would be great for you! Sorry I didn't see your message yesterday.

sboy99 commented 1 year ago

Screenshot from 2023-02-13 16-57-32

Almost done, One query what would be be the maximum height? As in large screen this is happening

Screenshot from 2023-02-13 17-01-19

ghost commented 1 year ago

What about h-64? That's 256px in TailwindCSS