search

mintlify / components

UI components for documentation made with React and TailwindCSS.
MIT License
79 stars 12 forks source link

add background to cover code text #88

Closed bryankang closed 1 year ago

bryankang commented 1 year ago
image image

I believe the user was explicitly setting the content to nowrap which is probably not optimized for this component. There's still the side effect of partially covering the text, but I didn't want to change too much and possibly break things visually since I don't have enough context/time.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

bryankang commented 1 year ago

that was my first attempt, but i saw that there are two variations of this component, and it will affect the other. but i'll see what i can do - just didn't want to spend too much time on this because of the main project

bryankang commented 1 year ago

yeah so i think i got it. i need to double check with the other filename variant, but it looks like this.

image

is this good? if not, i can come up with a fitting scroll bar design and implement it. again, i'm just not sure how far we want to take these things given that i only have 2 days left