search

mintopia / musicparty

Collaborative Music Party Jukebox
MIT License
11 stars 6 forks source link

Login in new window #9

Closed VibroAxe closed 1 year ago

VibroAxe commented 1 year ago

Not even sure where to start on an implementation but it would be really helpful to have the login to discord processed in a separate window. This would allow embedding music party into an iframe (such as organizr) without running into discord CORS / SSL issues.

VibroAxe commented 1 year ago

Easy mode would be to give the login link in https://github.com/mintopia/musicparty/blob/b8334aa7e45f5f65a0c7e72c3f304eb5f0674272/resources/views/home/index.blade.php#L61 a target to force it to "pop out", however I'm not sure how you would then collect the response back to the original parent window to refresh and complete the login process

VibroAxe commented 1 year ago

https://javascript.plainenglish.io/how-to-create-a-popup-for-oauth-login-38dee97f5f3b seems like it might do the trick