search

mintproject / MINT-ModelCatalogExplorer

A repository to show and explore models included in the MINT Model Catalog
0 stars 0 forks source link

Certain components not compatible with Polymer 3.x #38

Open dhruvp-8 opened 5 years ago

dhruvp-8 commented 5 years ago

Certain components like paper-autocomplete-chip, paper-chip which are crux of the application are not compatible with Polymer 3.x

dgarijo commented 5 years ago

Can they be changed?

dhruvp-8 commented 5 years ago

I am currently going through the code base of those components. Maybe we can refactor the code.

dgarijo commented 5 years ago

Isn't there another component that does similar functionality? I find very odd that they just dropped them out

dhruvp-8 commented 5 years ago

Actually the component we were using was a custom component made my some developer which was better than the default component. The developer's component has not been updated which causes this issue

PS: If it doesn't work then I think we have to customize the default component.

dgarijo commented 5 years ago

@dhruvp-8 after speaking to @varunratnakar today, he recommended having a look at https://www.webcomponents.org/element/vaadin/vaadin-combo-box

It's for polymer 3 and it's a similar component in functionality.

dhruvp-8 commented 5 years ago

Ok, I will look into it. Thanks

dhruvp-8 commented 5 years ago

@dgarijo The element suggested by @varunratnakar works perfect the only problem is it does not have the text highlighting feature. Rest seems good.

dgarijo commented 5 years ago

Can you have a look if highlighting is in the options? Or maybe it's easy to extend: https://github.com/vaadin/vaadin-combo-box/issues/106

dhruvp-8 commented 5 years ago

I am working on text highlighting may we can extend the component.