mintproject / MINT-Transformation

MIT License
3 stars 1 forks source link

0506 Demo For Daniel #66

Closed sumwmer closed 4 years ago

sumwmer commented 4 years ago

Demo steps:

minhptx commented 4 years ago

@dgarijo @sirspock please review and let us know if this is what you guys want.

dgarijo commented 4 years ago

Thanks Minh, we will take a look and let you know. One question: why is this the PR blocked? Am I supposed to review and accept it?

minhptx commented 4 years ago

Thanks Minh, we will take a look and let you know. One question: why is this the PR blocked? Am I supposed to review and accept it?

I added you as a reviewer. You can review and approve the the PR.

dgarijo commented 4 years ago

I reviewed it and it looks good. I will give it a try.

dgarijo commented 4 years ago

@summer7xinting @minhptx one question: The output file is specified to be climate_all.rts. However, there is another one generated (climate_all.rti). Without the rti file, the rts won't work. Why is it not then specified as output file?

minhptx commented 4 years ago

@dgarijo I see. I'll ask Xinting to fix this. When Scott asked us to run his transformation, he only need the rts file. That's why we assume only the rts files are needed.

sumwmer commented 4 years ago

I suppose we need to specify output file path and file name (without rts and rti extension)?

dgarijo commented 4 years ago

No, I think both are in tandem. Also, the input to the topoflow model is a zipped file. Is it possible to create it as a zipped file at the end? This is a technicality, but it would make it ready to plug in the model

sumwmer commented 4 years ago

In the case of generating a zipped file, it's reasonable to give a path/climate_all.zip and the adapter will take care of the rest.

dgarijo commented 4 years ago

Is it possible to have it as part of this example?

sumwmer commented 4 years ago

Creating another PR now