Closed sumwmer closed 4 years ago
@dgarijo @sirspock please review and let us know if this is what you guys want.
Thanks Minh, we will take a look and let you know. One question: why is this the PR blocked? Am I supposed to review and accept it?
Thanks Minh, we will take a look and let you know. One question: why is this the PR blocked? Am I supposed to review and accept it?
I added you as a reviewer. You can review and approve the the PR.
I reviewed it and it looks good. I will give it a try.
@summer7xinting @minhptx one question: The output file is specified to be climate_all.rts. However, there is another one generated (climate_all.rti). Without the rti file, the rts won't work. Why is it not then specified as output file?
@dgarijo I see. I'll ask Xinting to fix this. When Scott asked us to run his transformation, he only need the rts file. That's why we assume only the rts files are needed.
I suppose we need to specify output file path and file name (without rts and rti extension)?
No, I think both are in tandem. Also, the input to the topoflow model is a zipped file. Is it possible to create it as a zipped file at the end? This is a technicality, but it would make it ready to plug in the model
In the case of generating a zipped file, it's reasonable to give a path/climate_all.zip
and the adapter will take care of the rest.
Is it possible to have it as part of this example?
Creating another PR now
Demo steps:
/tmp/demo/input
/tmp/demo/input
: downloaded from heredocker run --rm -p 5000:5000 -v $(pwd):/ws -v /tmp:/tmp -it mint_dt bash /ws/examples/topoflow4/run_climate.sh
/tmp/demo/output
: should produceclimate_all.rti
andclimate_all.rts
correctly Note: previous config file and adapter variable naming is out of place so I fixed that ;)