search

mintproject / wcm

WINGS Component Manager
Apache License 2.0
1 stars 2 forks source link

Error on naming when downloading component #19

Open dgarijo opened 4 years ago

dgarijo commented 4 years ago

I downloaded cycles-0.9.4-alpha. Instead, the component I got was "alpha"

Cmheidelberg commented 4 years ago

wcm doesn't like multiple hyphens. Right now the only way to get version from wings is from the name of the component since there is no "Version" field in the wings portal. so wcm just splits the component at the hyphen to find the name and version Ex: HAND-v1 becomes

name: "HAND"
version: "v1"

@dgarijo was the name: cycles and version: alpha or was the name: alpha? Because im pretty sure name is the first instance and version is the last. So cycles-0.9.4-alpha was split up like ["cycles","0.9.4","alpha"]. Where the name becomes "cycles" and version gets "alpha".

There are several possible solutions to this I can think of. Standardized naming convention. Adding variable parameter to wings portal so we dont have to use this "sketchy" naming method. Or I could change how wcm download parses name and version, but this will break down if someone puts the component name separated with hyphen: like HAND-arizona-v5.

dgarijo commented 4 years ago

I will let you propose a solution. Changing wings at this stage is not desirable. Probably a good naming convention/disambiguation on wcm would be fine. For example, when downloading if there are hyphens, you could ask how the component will be saved