mintsoft / kodi.plugin.ytchannels

kodi.plugin.ytchannels
GNU General Public License v3.0
5 stars 8 forks source link

add ability to add playlist to a folder #20

Closed yeahme49 closed 2 years ago

yeahme49 commented 3 years ago

When viewing playlists, this allows you to pull up the context menu and add a playlist to a folder, so it shows up like a channel. Going to add the ability to add a playlist by ID at some point, but i'm not ready for that part yet

mintsoft commented 3 years ago

Thanks, I'll give this a test in a sec

mintsoft commented 3 years ago

OK, stupid question time: how do I actually use the new functionality?

Edit: I found it; I'd messed up deploying the updated code to my test installation Ediit2: Still don't quite understand what functionality it is adding other than seeing playlists?

mintsoft commented 2 years ago

Sorry @yeahme49 I've only just managed to find time to look at this again. I've just pulled the version as it stands now and I get the following error running it under Kodi 18.8:

2021-07-21 19:26:48.951 T:13056   ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                             - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                            Error Type: <type 'exceptions.SyntaxError'>
                                            Error Contents: invalid syntax (functions.py, line 17)
                                            Traceback (most recent call last):
                                              File "C:\Users\Rob\AppData\Roaming\Kodi\addons\plugin.video.ytchannels\default.py", line 2, in <module>
                                                from resources.lib.ytchannels import ytchannels_main
                                              File "C:\Users\Rob\AppData\Roaming\Kodi\addons\plugin.video.ytchannels\resources\lib\ytchannels.py", line 10, in <module>
                                                from .functions import local_string
                                              File "C:\Users\Rob\AppData\Roaming\Kodi\addons\plugin.video.ytchannels\resources\lib\functions.py", line 17
                                                else
                                                   ^
                                            SyntaxError: invalid syntax
                                            -->End of Python script error report<--
mintsoft commented 2 years ago

I've just undone https://github.com/mintsoft/kodi.plugin.ytchannels/pull/20/commits/357dffcb2601a4cf39ef73ec9619cf8fed44df37 on my version here so I can test again. I've just realised what I was doing wrong last time which was why I couldn't see the functionality (human error of course). So I think it's probably good to go, excluding the compilation error at the moment!

yeahme49 commented 2 years ago

should be fixed now

mintsoft commented 2 years ago

Cool, all good. Thanks for your patience @yeahme49

mintsoft commented 2 years ago

https://github.com/xbmc/repo-plugins/pull/3681 https://github.com/xbmc/repo-plugins/pull/3680