search

mintsoft / kodi.plugin.ytchannels

kodi.plugin.ytchannels
GNU General Public License v3.0
5 stars 8 forks source link

Unnecessary YouTube id listings in Kodi log #43

Closed jirkoun closed 7 months ago

jirkoun commented 7 months ago

I use YTChannel as a source for several widgets and I have to say that Youtube id listings are quite annoying. The list of those ids is completely useless, it does not carry any useful information and just makes the log less clear with unnecessary ballast.

Today, in the functions.py module in def get_latest_from_channel(), all ids are logged (with LOGINFO status) and then once again separately those that do not pass the "short videos" filter (conditionally, if this filter is set).

I can think of two ways to solve this:

  1. Add a condition enabling/disabling (perhaps default as disabling) this logging to the plugin settings - but this seems to me to be an unnecessary complication and especially lay users will not fully realize what it is actually there for
  2. Simply change the status of both log entries to LOGDEBUG - after all, I still think that log entry is only there for debugging purposes
mintsoft commented 7 months ago

Yep, those logs are definitely there for only for debugging, I'll just rip them out

mintsoft commented 7 months ago

https://github.com/xbmc/repo-plugins/pull/4420