search

mintty / wsltty

Mintty as a terminal for Bash on Ubuntu on Windows / WSL
Other
3.12k stars 104 forks source link

Windows update broke wsltty #281

Closed f-a-a closed 3 years ago

f-a-a commented 3 years ago

Recent Windows 10 update to version 21364.1000 (Build 21364.co_release.210416-1504) throws this error when running wslbridge2.exe:

assertion "hRes == 0" failed: file "GetVmId.cpp", line 47, function: HRESULT GetVmId(GUID*, const wstring&, int*)
      0 [main] wslbridge2 49 cygwin_exception::open_stackdumpfile: Dumping stack trace to wslbridge2.exe.stackdump

Not sure if this is the correct place to file this issue but I hope to get some leads on this

jraffa commented 3 years ago

I got something similar with the same release:

assertion "hRes == 0" failed: file "GetVmId.cpp", line 43, function: HRESULT GetVmId(GUID*,const wstring&, int*)

Biswa96 commented 3 years ago

OK, I'm waiting for this bug 😈 I've already fix the issue in wslbridge2. If mintty needs I can tag a point release.

mintty commented 3 years ago

My version is 19041; I guess 21364 is in the "fast" release cycle, right?

@Biswa96, I've updated my patch set once but I'd prefer if we can integrate the inband-resize handling on this occasion, so I can simply catch-up with the latest wslbridge2 release in the future.

Biswa96 commented 3 years ago

I guess 21364 is in the "fast" release cycle, right?

Yes. It's in Insider release cycle. I have added v0.8 in wslbridge2 with the fix https://github.com/Biswa96/wslbridge2/releases/tag/v0.8

Speaking of the resize handling, I have not thought about it. I was exploring some Win32 console APIs then 2020 happened. Can you please edit the patch here at wsltty just last time? There will not be any monumental change 🤞

mintty commented 3 years ago

Released 3.5.0.2, marked as pre-release for now. Please test.

Biswa96 commented 3 years ago

Insiders, any test report?

f-a-a commented 3 years ago

@mintty @Biswa96 I can confirm version 3.5.0.2 now works without the reported error above. Thank you for the fix!

jraffa commented 3 years ago

works for me too. thx!

Biswa96 commented 3 years ago

So, will now the wsltty release be out of test? @mintty

mintty commented 3 years ago

Oh, yes. Thanks for reminding.